REV10 Bug ? command

Drakelive · February 2, 2024, 12:01am

Hi Ian
With the latest firmware version I have a display problem with the command: Hiz> ?
Maybe some New line is missing

LouD · February 2, 2024, 9:19am

It seems there is a \r\n missing after the two dash_line in right column?

github.com

DangerousPrototypes/BusPirate5-firmware/blob/191b88b31bcb4ac1bcf2988b0a4721d5da0eb98d/ui/ui_info.c#L370-L402


      
          void ui_info_print_help(opt_args (*args), struct command_result *res)

          {

          	//printf("\t%s%s%s\r\n", ui_term_color_info(), t[T_HELP_TITLE], ui_term_color_reset());

          	//printf("----------------------------------------------------------------------------\r\n");

          

          	const char dash_line[]="--------------------------------------";

          	

          	for(uint i=0; i<count_of(help_commands); i++)

          	{

          		if(!help_commands[i].help)

          		{

          			printf("%s%s%s\t%s%s%s\t",

          				ui_term_color_prompt(), help_commands[i].command, ui_term_color_reset(),

          				ui_term_color_info(), t[help_commands[i].description], ui_term_color_reset()

          			);

          		}

          		else

          		{

          			printf("%s%s\t", ui_term_color_reset(), dash_line);

          		}

This file has been truncated. show original

ian · February 2, 2024, 1:33pm

Thank you so much. I’ll push a fix

ian · February 2, 2024, 3:25pm

Fix pushed. Thank you again for the report.

Drakelive · February 2, 2024, 7:55pm

HI

I’ve updated my repository to the latest change posted by @ian but I still find one thing incorrect regarding the “b” menu which doesn’t seem to be supported yet.

I solved it by commenting lines 308 and 334 of the ui/ui_info.c file obtaining a more readable output.

Perhaps on Gihub we should divide the project into multiple branches to have an official stable version (main branch), a development version (Branch dev) and the various versions (main_stable_v1.1.0)
What do you think ?

Drk

ian · February 3, 2024, 6:10pm

That’s probably a good idea. I don’t remember why the b command place holder is there. Removing that line did also remove the bus syntax section separator ---- line.

With the merge of the scope, the help is going to get a rework.

The two columns are cute, but in the past they fit in one screen, now you need to scroll back to read them.

A single column would be a LOT easier to maintain long term. The two columns stuff is hacky, and the translation names are ugly.

I also think we need to make help a little more interactive, more like Linux man command (is that right?). Paul added hd command for display mode help, but I’d like to wrap general help, mode help, and display help into the same system.

grymoire · February 9, 2024, 3:13pm

On a help command… You can either have a “?” option to all commands to explain each command in detail. Or have the command follow ? - which I think is more like the Unix man command, Having “command ?” is more like Unix’s "command -h"convention.
Or you could have both versions. I suppose if necessary you have a help mode with multiple pages or levels - primary and secondary commands.